OCTADE |
mail  files  register  groups  login |
1 |
<v5c1nk$v3ah$1@dont-email.me>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=547&group=rocksolid.nodes.help#547
copy link Newsgroups: rocksolid.nodes.helpHello!
https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
When replying to that post and inserting the quote, additional blank
lines are added at the end.
[...]
> Gruß, ULF
====END of Quote
--
kind regards
Marco
Send spam to 1719240931muell@cartoonies.org
<8e538b55b26be8e838a0ece7040b8ff7$1@invalid.invalid>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=548&group=rocksolid.nodes.help#548
copy link Newsgroups: rocksolid.nodes.helpOn Mon, 24 Jun 2024 17:01:07 +0200, Marco Moock wrote:
> <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
Between the dashed lines below is what I get when hitting 'Quote' in my
devel copy of rslight.
Are there more blank lines than you see there?
rslight does strip blank lines at the end when posting, but not replying. I
could add that if necessary.
I'm going to read Stefan's message now, maybe it's worse? I'll check...
--------------------------------
Ulf_Kutzner wrote:
> Marco Moock wrote:
>> Am 17.05.2024 10:16 Uhr schrieb Marco Moock:
>>> Wenn man den Originalbeitrag gequotet einfügt, fehlen da bei den
>>> umgebrochenen Zeilen in der Tat die ">".
>>>
>>> Dort wird das jetzt diskutiert:
>>> <v273lb$226q6$3@dont-email.me>
>> Die neue Version ist nun bei mir installiert.
>> Gerne testen und mir rückmelden, wenn es noch Probleme gibt.
> Manchmal findet sich nun als vorletzte Zitatzeile eine
> Leerzeile, wo vorher keine war. Zum Beispiel in meinem
> Posting von gerade eben zu einem Haltverbotsthema.
> Gruß, ULF
----------------------------
<02821402b51d5c61a489adad11745d19$1@invalid.invalid>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=549&group=rocksolid.nodes.help#549
copy link Newsgroups: rocksolid.nodes.helpOn Mon, 24 Jun 2024 08:40:24 -0700, Retro Guy wrote:
> On Mon, 24 Jun 2024 17:01:07 +0200, Marco Moock wrote:
>
>> <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
>
> Between the dashed lines below is what I get when hitting 'Quote' in my
> devel copy of rslight.
>
> Are there more blank lines than you see there?
>
> rslight does strip blank lines at the end when posting, but not replying. I
> could add that if necessary.
>
> I'm going to read Stefan's message now, maybe it's worse? I'll check...
>
>
> --------------------------------
> Ulf_Kutzner wrote:
>
>> Marco Moock wrote:
>
>>> Am 17.05.2024 10:16 Uhr schrieb Marco Moock:
>
>>>> Wenn man den Originalbeitrag gequotet einfügt, fehlen da bei den
>>>> umgebrochenen Zeilen in der Tat die ">".
>>>>
>>>> Dort wird das jetzt diskutiert:
>>>> <v273lb$226q6$3@dont-email.me>
>
>>> Die neue Version ist nun bei mir installiert.
>>> Gerne testen und mir rückmelden, wenn es noch Probleme gibt.
>
>> Manchmal findet sich nun als vorletzte Zitatzeile eine
>> Leerzeile, wo vorher keine war. Zum Beispiel in meinem
>> Posting von gerade eben zu einem Haltverbotsthema.
>
>> Gruß, ULF
>
>
> ----------------------------
Also, if you telnet to your server and look at the article, are there blank
lines in the article itself?
For Stefan's article, I need to backload the group as my devel rslight
doesn't carry it. I'll check it when it's done loading articles.
<v5c4o0$v3ah$2@dont-email.me>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=550&group=rocksolid.nodes.help#550
copy link Newsgroups: rocksolid.nodes.helpOn 24.06.2024 um 08:42 Uhr Retro Guy wrote:
> Also, if you telnet to your server and look at the article, are there
> blank lines in the article itself?
I haven't seen any in my newsreader Claws Mail.
--
kind regards
Marco
Send spam to 1719211358muell@cartoonies.org
<781294a831cfac80cf51a8e86a6d1ad8@example.com>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=559&group=rocksolid.nodes.help#559
copy link Newsgroups: rocksolid.nodes.helpIf you wish to try the (hopefully) fix. Add one line to newsportal.php
(line 2890 in devel copy).
Find the function 'wrap_post', and right below the 'foreach' add the
line:
$line = rtrim($line);
function wrap_post($body)
{
$line_length = 72;
$lines = preg_split("/\n/", $body);
$wrapped = '';
foreach ($lines as $line) {
$line = rtrim($line); <-----HERE
if (trim($line) == '') {
$wrapped .= "\n";
continue;
}
--
Retro Guy
<v5ek1i$1j04p$1@dont-email.me>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=560&group=rocksolid.nodes.help#560
copy link Newsgroups: rocksolid.nodes.helpOn 24.06.2024 um 19:32 Uhr Retro Guy wrote:
> If you wish to try the (hopefully) fix. Add one line to newsportal.php
> (line 2890 in devel copy).
Is it already in the repository or do I need to do that manually?
If so, how will it affect future updates when using the install script?
--
kind regards
Marco
Send spam to 1719250324muell@cartoonies.org
<992beb584598fefe171755aa97369806$1@invalid.invalid>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=561&group=rocksolid.nodes.help#561
copy link Newsgroups: rocksolid.nodes.helpOn Tue, 25 Jun 2024 16:25:54 +0200, Marco Moock wrote:
> On 24.06.2024 um 19:32 Uhr Retro Guy wrote:
>
>> If you wish to try the (hopefully) fix. Add one line to newsportal.php
>> (line 2890 in devel copy).
>
> Is it already in the repository or do I need to do that manually?
> If so, how will it affect future updates when using the install script?
It's not in the repo yet, still in devel. I don't want to push devel yet as
I made some changes today that I want to continue testing.
If you make the change, it's fine. Upgrading from the repo next time will
just overwrite newsportal.php, so no negative effect.
<v5g9ds$20ck2$1@dont-email.me>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=562&group=rocksolid.nodes.help#562
copy link Newsgroups: rocksolid.nodes.helpOn 24.06.2024 um 19:32 Uhr Retro Guy wrote:
> If you wish to try the (hopefully) fix. Add one line to newsportal.php
> (line 2890 in devel copy).
I've added it, but the situation is the same, the blank lines at the
end are still present.
Just reply to this post and insert the quote:
https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
It is also not message-specific, it happens with other messages too
when replying to them.
Message-ID: <v25lnk$cocr$2@solani.org>
--
kind regards
Marco
Send spam to 1719250324muell@cartoonies.org
<f812b177642b4f312cb1a98b891f5dca@www.novabbs.org>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=563&group=rocksolid.nodes.help#563
copy link Newsgroups: rocksolid.nodes.helpMarco Moock wrote:
> On 24.06.2024 um 19:32 Uhr Retro Guy wrote:
>> If you wish to try the (hopefully) fix. Add one line to newsportal.php
>> (line 2890 in devel copy).
> I've added it, but the situation is the same, the blank lines at the
> end are still present.
> Just reply to this post and insert the quote:
> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
> Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
> It is also not message-specific, it happens with other messages too
> when replying to them.
> Message-ID: <v25lnk$cocr$2@solani.org>
I think maybe yours and Stefan's issues were different. His concern,
which I believe I have fixed, was blank lines being inserted inside a
quote (between quoted lines) and I'm seeing that maybe you are seeing
blank lines at the end of quoted text.
Do I understand correctly?
I will add address the blank lines at the end now. The fix I sent was
for blank lines inside a quote.
--
Retro Guy
<01291e2152639f8f95371b3075a26c31@www.novabbs.org>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=564&group=rocksolid.nodes.help#564
copy link Newsgroups: rocksolid.nodes.helpRetro Guy wrote:
> Marco Moock wrote:
>> On 24.06.2024 um 19:32 Uhr Retro Guy wrote:
>>> If you wish to try the (hopefully) fix. Add one line to newsportal.php
>>> (line 2890 in devel copy).
>> I've added it, but the situation is the same, the blank lines at the
>> end are still present.
>> Just reply to this post and insert the quote:
>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
>> Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
>> It is also not message-specific, it happens with other messages too
>> when replying to them.
>> Message-ID: <v25lnk$cocr$2@solani.org>
> I think maybe yours and Stefan's issues were different. His concern,
> which I believe I have fixed, was blank lines being inserted inside a
> quote (between quoted lines) and I'm seeing that maybe you are seeing
> blank lines at the end of quoted text.
> Do I understand correctly?
> I will add address the blank lines at the end now. The fix I sent was
> for blank lines inside a quote.
Ok, please try to click on Quote for any article on
www.novabbs.(com|org). I have removed the blank lines at the end.
If you are happy with the result, go ahead and apply the latest devel. I
run it on all my sites and not seeing issues.
Please let me know if this is the result you were looking for, thanks!
--
Retro Guy
<v5gh0l$219po$1@dont-email.me>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=565&group=rocksolid.nodes.help#565
copy link Newsgroups: rocksolid.nodes.helpOn 26.06.2024 um 06:28 Uhr Retro Guy wrote:
> Retro Guy wrote:
>
> > Marco Moock wrote:
>
> >> On 24.06.2024 um 19:32 Uhr Retro Guy wrote:
>
> >>> If you wish to try the (hopefully) fix. Add one line to
> >>> newsportal.php (line 2890 in devel copy).
>
> >> I've added it, but the situation is the same, the blank lines at
> >> the end are still present.
>
> >> Just reply to this post and insert the quote:
> >> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
> >> Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
>
> >> It is also not message-specific, it happens with other messages too
> >> when replying to them.
> >> Message-ID: <v25lnk$cocr$2@solani.org>
>
> > I think maybe yours and Stefan's issues were different. His concern,
> > which I believe I have fixed, was blank lines being inserted inside
> > a quote (between quoted lines) and I'm seeing that maybe you are
> > seeing blank lines at the end of quoted text.
>
> > Do I understand correctly?
>
> > I will add address the blank lines at the end now. The fix I sent
> > was for blank lines inside a quote.
>
> Ok, please try to click on Quote for any article on
> www.novabbs.(com|org). I have removed the blank lines at the end.
>
> If you are happy with the result, go ahead and apply the latest
> devel. I run it on all my sites and not seeing issues.
>
> Please let me know if this is the result you were looking for, thanks!
Looks good.
--
kind regards
Marco
Send spam to 1719376125muell@cartoonies.org
<3b2dcc2e4c8f569bc4cf383d7cbf7b33@www.novabbs.org>
copy midhttps://news.octade.net/rocksolid/article-flat.php?id=566&group=rocksolid.nodes.help#566
copy link Newsgroups: rocksolid.nodes.helpMarco Moock wrote:
> On 26.06.2024 um 06:28 Uhr Retro Guy wrote:
>> Retro Guy wrote:
>>
>> > Marco Moock wrote:
>>
>> >> On 24.06.2024 um 19:32 Uhr Retro Guy wrote:
>>
>> >>> If you wish to try the (hopefully) fix. Add one line to
>> >>> newsportal.php (line 2890 in devel copy).
>>
>> >> I've added it, but the situation is the same, the blank lines at
>> >> the end are still present.
>>
>> >> Just reply to this post and insert the quote:
>> >>
>> https://pi-dach.dorfdsl.de/rocksolid/article-flat.php?id=1867&group=de.soc.recht.misc#1867
>> >> Message-ID: <72cf4106b08b0f77f76b03f3dcad8338@pi-dach.dorfdsl.de>
>>
>> >> It is also not message-specific, it happens with other messages too
>> >> when replying to them.
>> >> Message-ID: <v25lnk$cocr$2@solani.org>
>>
>> > I think maybe yours and Stefan's issues were different. His concern,
>> > which I believe I have fixed, was blank lines being inserted inside
>> > a quote (between quoted lines) and I'm seeing that maybe you are
>> > seeing blank lines at the end of quoted text.
>>
>> > Do I understand correctly?
>>
>> > I will add address the blank lines at the end now. The fix I sent
>> > was for blank lines inside a quote.
>>
>> Ok, please try to click on Quote for any article on
>> www.novabbs.(com|org). I have removed the blank lines at the end.
>>
>> If you are happy with the result, go ahead and apply the latest
>> devel. I run it on all my sites and not seeing issues.
>>
>> Please let me know if this is the result you were looking for, thanks!
> Looks good.
Great! Glad it's working.
--
Retro Guy
1 |